Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin and update requirements #44

Merged
merged 12 commits into from
Jul 12, 2024
Merged

Unpin and update requirements #44

merged 12 commits into from
Jul 12, 2024

Conversation

thisac
Copy link
Collaborator

@thisac thisac commented Dec 7, 2023 •
edited
Loading

  • Unpins dev requirements
  • Updates requirements for compatibility
  • Adds pyqir as an optional dependency and removes the version check.

@thisac thisac self-assigned this Dec 7, 2023
@thisac thisac force-pushed the fix-unpin-requirements branch from 17a9d63 to 11f4cd1 Compare December 7, 2023 01:55
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5499b1f) to head (72ffc9e).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1550      1545    -5     
  Branches       263       263           
=========================================
- Hits          1550      1545    -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thisac thisac requested a review from randomir December 7, 2023 01:59
@thisac
Copy link
Collaborator Author

thisac commented Dec 7, 2023

I tried updating to pyqir=0.10.0 but the Linux tests were failing (see here), probably due to the manylinux change here (and around). Staying at 0.9.0 for now.

randomir
randomir reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@randomir randomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few comments about version parsing and comparison, but otherwise looks good (the relaxed test requirements).

dwave/gate/qir/__init__.py Outdated Show resolved Hide resolved
dwave/gate/qir/__init__.py Outdated Show resolved Hide resolved
dwave/gate/qir/__init__.py Outdated Show resolved Hide resolved
@thisac thisac requested a review from randomir December 7, 2023 17:30
thisac
thisac commented Dec 21, 2023
View reviewed changes
docs/reference/qir.rst
Comment on lines +1 to +2
QIR
===
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had forgotten to add QIR to the docs.

@thisac thisac force-pushed the fix-unpin-requirements branch 2 times, most recently from c44b5d2 to 0b7a3dd Compare July 12, 2024 22:50
@thisac thisac force-pushed the fix-unpin-requirements branch from 0b7a3dd to 56df4d6 Compare July 12, 2024 22:59
@thisac thisac requested review from randomir and arcondello July 12, 2024 23:03
arcondello
arcondello approved these changes Jul 12, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@thisac thisac merged commit 4bbf1f0 into dwavesystems:main Jul 12, 2024
32 checks passed
@thisac thisac deleted the fix-unpin-requirements branch July 12, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcondello arcondello arcondello approved these changes

@randomir randomir Awaiting requested review from randomir

Assignees

@thisac thisac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisac @randomir @arcondello