feat: Generate class-groups key pair & proof with crypto lib #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ItayLevyOfficial
force-pushed
the
369-real-class-groups-keygen
branch
from
fdb94e6 to
2dad3a3
Compare
Base automatically changed from
400-dwallet-super-user
to
393-async-network-dkg
December 23, 2024 15:11
ItayLevyOfficial
approved these changes
Dec 25, 2024
crates/dwallet-mpc-types/src/lib.rs
Outdated
There was a problem hiding this comment.
create mock keypairs and proofs we'll be able to keep using for local development
yaelAbergel
commented
Dec 30, 2024
yaelAbergel
commented
Dec 30, 2024
sdk/dwallet-mpc-wasm/src/lib.rs
Outdated
There was a problem hiding this comment.
I had to modify this file because of the updated API of the cryptography-private lib.
yaelAbergel
force-pushed
the
369-real-class-groups-keygen
branch
2 times, most recently
from
079cdcc to
112cf68
Compare
yaelAbergel
force-pushed
the
369-real-class-groups-keygen
branch
from
112cf68 to
31acde9
Compare
yaelAbergel
commented
Dec 31, 2024
…oups-keygen # Conflicts: # crates/pera-core/src/dwallet_mpc/mpc_manager.rs
…ass-groups-keygen # Conflicts: # Cargo.lock # Cargo.toml # crates/class-groups-constants/src/lib.rs # crates/dwallet-classgroups-types/src/lib.rs # crates/pera-config/src/node.rs # crates/pera-core/src/authority/authority_per_epoch_store.rs # crates/pera-core/src/dwallet_mpc/mpc_manager.rs # crates/pera-core/src/dwallet_mpc/mpc_session.rs # crates/pera-keys/src/keypair_file.rs # crates/pera-swarm-config/src/genesis_config.rs # sdk/dwallet-mpc-wasm/Cargo.lock
yaelAbergel
commented
Jan 2, 2025
crates/pera-keys/src/keypair_file.rs
Outdated
zeevmoney
requested changes
Jan 6, 2025
crates/pera-framework/packages/pera-system/sources/dwallet_network_key.move
Show resolved
Hide resolved
Comment on lines
+381
to
+383
| public(package) fun emit_validator_data_for_secret_share(data: ValidatorDataForDWalletSecretShare) { | ||
| event::emit(data); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public(package) fun emit_validator_data_for_secret_share(data: ValidatorDataForDWalletSecretShare) { | |
| event::emit(data); | |
| } |
crates/pera-framework/packages/pera-system/sources/pera_system_state_inner.move
Outdated
Show resolved
Hide resolved
| @@ -347,32 +352,54 @@ module pera_system::validator_set { | |||
| // ==== epoch change functions ==== | |||
|
|
|||
| public(package) fun lock_next_epoch_committee(self: &mut ValidatorSet, epoch: u64) { | |||
| let mut next_epoch_vals = vector::empty(); | |||
| let mut _next_epoch_vals = vector::empty(); | |||
crates/pera-framework/packages/pera-system/sources/validator_set.move
Outdated
Show resolved
Hide resolved
Co-authored-by: Zeev Manilovich <zeevmoney@users.noreply.github.com>
zeevmoney
reviewed
Jan 6, 2025
Comment on lines
37
to
43
| let validators_len = validators_data.length(); | ||
| let mut i = 0; | ||
| while (i < validators_len) { | ||
| let validator_data = validators_data[i]; | ||
| emit_validator_data_for_secret_share(validator_data); | ||
| i = i + 1; | ||
| } |
There was a problem hiding this comment.
Suggested change
| let validators_len = validators_data.length(); | |
| let mut i = 0; | |
| while (i < validators_len) { | |
| let validator_data = validators_data[i]; | |
| emit_validator_data_for_secret_share(validator_data); | |
| i = i + 1; | |
| } | |
| let mut i = 0; | |
| while (i < validators_data.length()) { | |
| emit_validator_data_for_secret_share(validators_data[i]); | |
| i = i + 1; | |
| } |
zeevmoney
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the real Class-Groups key generation logic was not fully implemented, and each generation process took a long time.
This PR introduces the actual functions and types required for the Class-Groups key generation. It also stores each validator's encryption key and proof on-chain.
Notes:
mock-class-groupsfeature in "dev" mode takes a significant amount of time, though it is faster in "release" mode.