Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing a content fragment at conversation creation #1972

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Allow passing a content fragment at conversation creation #1972

merged 2 commits into from
Oct 5, 2023

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Oct 5, 2023 •
edited
Loading

Fixes #1958

  • Allow passing a content fragment as part of the conversation creation (API)
  • Update to docs
  • Move message (and contentFragment) as undefined instead of null in the schema so that they are really optional

@spolu spolu requested a review from lasryaric October 5, 2023 10:53
@spolu
Copy link
Contributor Author

spolu commented Oct 5, 2023

Post-merge review welcome

@spolu spolu merged commit 55d8c37 into main Oct 5, 2023
@spolu spolu deleted the spolu-content_fragment_at_conversation_creation branch October 5, 2023 11:35
@spolu
Copy link
Contributor Author

spolu commented Oct 5, 2023

Tested locally end-to-end with Dust-Staging slack bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasryaric lasryaric Awaiting requested review from lasryaric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Slack-V2] Add support for creating a Content Fragment when creating a conversation
1 participant
@spolu