Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to move the specific systems code to their own submodules. The motivation behind is that this will help organize the code, and make it more obvious where to put new systems in the future.
As a result of moving the code, this uncovered some accrued technical debt in our import systems and circular scheme dependencies. I have attempted to resolve this by 1. Moving type checking imports under
TYPE_CHECKING
where possible, 2. breaking circularity in systems by moving some imports into functions (reminder for future us, do not mix config, models, and application code), 3. using factories in the cli config (you cannot forward reference models needed to generate defaults otherwise), and 4. revising how the config is passed to the systems.At this point, tests are passing and mypy is happy.
Closes #633
TODO
systems/jetto
(follow-up PR)