chore: review solana trades setup #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xRobin
added
ready-for-review
jeff-dude
reviewed
May 24, 2024
| @@ -1,7 +1,7 @@ | |||
| {{ config( | |||
| schema = 'magiceden_solana', | |||
| alias = 'events', | |||
|
|
|||
| tags =['prod_exclude'], | |||
There was a problem hiding this comment.
if we're just moving the lineage around, is there a reason this is explicitly excluded?
There was a problem hiding this comment.
ah good catch, I though it already was disabled.
Let's try one more time and see if the CI can handle it.
There was a problem hiding this comment.
oh boy, maybe CI can't handle it
jeff-dude
added
in review
0xRobin
added
WIP
|
waiting for #6026 to continue on this |
0xRobin
added
ready-for-review
jeff-dude
approved these changes
Jun 3, 2024
jeff-dude
added
ready-for-merging
and removed
blocked
ready-for-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This places the older solana models under the newer
nft_solana.tradesspell (be it with a lot of null columns).The PR also introduces a backlink from
nft_solana.tradesback tonft.base_tradesso we can have all solana trades in there as well (currently not completely linked as discussed with Alan)