-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Odos Ethereum and Base trades #5718
Conversation
Workflow run id 8526776877 approved. |
Workflow run id 8526776761 approved. |
Workflow run id 8555660997 approved. |
Workflow run id 8555661196 approved. |
models/odos/odos_trades.sql
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block_month
isn't being pulled in this view, so downstream is failing on the column missing:
https://github.com/duneanalytics/spellbook/blob/main/models/odos/odos_trades.sql#L24-L47
make sure all columns in dex_aggregator_trades.sql
are being selected in odos_trades.sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while in this spell, you can remove comment at the top about not migrated
Workflow run id 8569727093 approved. |
Workflow run id 8569727341 approved. |
Workflow run id 8569785309 approved. |
Workflow run id 8569785493 approved. |
@@ -33,7 +33,7 @@ with event_data AS ( | |||
contract_address AS project_contract_address, | |||
evt_tx_hash AS tx_hash, | |||
evt_index, | |||
array[-1] as trace_address | |||
CAST(ARRAY[-1] as array<bigint>) as trace_address, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accidental trailing comma on these changes :)
Workflow run id 8570411862 approved. |
Workflow run id 8570411985 approved. |
@jeff-dude checks passed! |
Thank you for contributing to Spellbook!
Thank you for taking the time to submit code in Spellbook. A few things to consider:
Best practices
To speed up your development process in PRs, keep these tips in mind:
readme
) and rundbt compile
target/
directory to copy/paste and run on Dune directly for initial query testingWHERE
filter for only ~7 days of history on large source tables, i.e.ethereum.transactions
Incremental model setup
COALESCE()
as needed on key column(s), otherwise the tests may fail on duplicates🪄 Use the built CI tables for testing 🪄
Once CI completes, you can query the CI tables and errors in dune when it finishes running.
run initial models
andtest initial models
, there will be a schema that looks like this:test_schema.git_dunesql_4da8bae_sudoswap_v2_base_pool_creations
Leverage these tables to perform QA testing on Dune query editor -- or even full test dashboards!
Spellbook contribution docs
The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each
.md
file within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄Example questions to be answered:
Please navigate through the docs directory to find as much info as you can.
Note: happy to take PRs to improve the docs, let us know 🤝