Feature/brad/js api overrides #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/iOS into feature/brad/js-api-overrides
SlayterDev
requested review from
brindy,
bwaresiak,
samsymons and
THISISDINOSAUR
as code owners
…/iOS into feature/brad/js-api-overrides
bwaresiak
reviewed
Dec 15, 2020
brindy
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:https://app.asana.com/0/0/1195460247972058/f
Tech Design URL: https://app.asana.com/0/481882893211075/1199166946567550/f
CC: @brindy @catehstn
Description:
This PR injects JavaScript to override some common fingerprinting APIs and replaces their values with safer alternatives.
Steps to test this PR:
Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template