Bugfix: Fix Youtube Internal links when 'Watching on Youtube' from Duck Player #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afterxleep
requested review from
a team and
federicocappelli
and removed request for
a team
federicocappelli
approved these changes
Dec 17, 2024
| @@ -582,4 +582,24 @@ class DuckPlayerNavigationHandlerTests: XCTestCase { | |||
| XCTAssertNil(tabNavigator.openedURL, "No new tabs should open") | |||
| } | |||
|
|
|||
| @MainActor | |||
There was a problem hiding this comment.
Is @mainactor needed here? I think that Bartek is working thorwards parallelising the unit tests and this could interfeer, In any case I don't think we should run tests on main therad.
There was a problem hiding this comment.
Good call. Although not required, it was to align with the convention that any code interacting with WebKit or UI components runs on the main thread.
Like If you replace MockWebView with a real WKWebView or integrate other WKNavigationDelegate-related logic in the future, @mainactor will help avoid threading issues. Not likely happen in a test though. I'll make a note to revise/update the class.
federicocappelli
approved these changes
Dec 17, 2024
samsymons
added a commit
that referenced
this pull request
Dec 19, 2024
# By Michal Smaga (10) and others # Via Michal Smaga (4) and others * main: (66 commits) DuckPlayer: Don’t open new tabs or DuckPlayer at launch when in alwaysAsk mode (#3738) Fix BrowsingMenu layout (#3712) Remove ESLint config files (#3739) Release 7.150.0-1 (#3742) An additional protective in case users try to access the passwords list via the extension, before launching the app Ensure migration has occurred before accessing vault Populate credential store if user has enabled before launching app Update to target main app Ensure migration has occurred before accessing vault Release 7.149.1-0 (#3740) An additional protective in case users try to access the passwords list via the extension, before launching the app Ensure migration has occurred before accessing vault Populate credential store if user has enabled before launching app Update to target main app Ensure migration has occurred before accessing vault Bugfix: Fix Youtube Internal links when 'Watching on Youtube' from Duck Player (#3733) point to BSK branch (#3732) Remove duck.ai 10min timer (#3731) Release 7.150.0-0 (#3729) Update autoconsent to v12.3.0 (#3728) ... # Conflicts: # Core/PixelEvent.swift # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204099484721401/1208930843675395/f
Tech Design URL:
CC:
Description:
Fixes an issue causing Youtube internal links to open Duck Player
Steps to test this PR:
Demo:
