Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(c): add functions for determining statement/return types #9430

Merged
merged 12 commits into from
Nov 20, 2023
Merged

feat(c): add functions for determining statement/return types #9430

merged 12 commits into from
Nov 20, 2023

Conversation

Mause
Copy link
Member

@Mause Mause commented Oct 22, 2023 •
edited
Loading

Fixes #8786

Mytherin
Mytherin reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good - one comment:

src/main/capi/result-c.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot marked this pull request as draft October 23, 2023 08:26
@Mause Mause marked this pull request as ready for review October 23, 2023 12:12
@Mause Mause requested a review from Mytherin October 25, 2023 00:30
@Mause Mause changed the base branch from main to feature November 1, 2023 06:11
@github-actions github-actions bot marked this pull request as draft November 7, 2023 13:41
@Mause Mause marked this pull request as ready for review November 8, 2023 05:31
@github-actions github-actions bot marked this pull request as draft November 8, 2023 13:34
@Mytherin Mytherin marked this pull request as ready for review November 8, 2023 13:34
@Mytherin
Copy link
Collaborator

Mytherin commented Nov 8, 2023

Thanks for the PR! LGTM - I've just removed the REQUIRE_SUCCESS macro as it seems confusing to me that REQUIRE_FAIL works with the C++ API and REQUIRE_SUCCESS works with the C API.

@Mytherin
Copy link
Collaborator

Mytherin commented Nov 8, 2023

Looks like some CI failures remain - could you have a look?

2023-11-08T13:55:26.6096848Z D:\a\duckdb\duckdb\src\main\capi\result-c.cpp(614,34): error C2061: syntax error: identifier 'PreparedStatementWrapper' [D:\a\duckdb\duckdb\src\main\capi\duckdb_main_capi.vcxproj]
2023-11-08T13:55:26.6552720Z D:\a\duckdb\duckdb\src\main\capi\result-c.cpp(616,26): error C3536: 'stmt': cannot be used before it is initialized [D:\a\duckdb\duckdb\src\main\capi\duckdb_main_capi.vcxproj]

@github-actions github-actions bot marked this pull request as draft November 10, 2023 08:50
@Mause Mause marked this pull request as ready for review November 12, 2023 02:30
@Mytherin Mytherin changed the base branch from feature to main November 20, 2023 12:43
@Mytherin Mytherin merged commit ce5a2ec into duckdb:main Nov 20, 2023
46 of 47 checks passed
@Mytherin
Copy link
Collaborator

Thanks

@Mause Mause deleted the c-api-extensions branch November 20, 2023 12:55
@Giorgi Giorgi mentioned this pull request Nov 24, 2023
Closed
2 tasks
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 11, 2023
@krlmlr
chore: Update vendored sources to duckdb/duckdb@ce5a2ec
e414113 
Merge pull request duckdb/duckdb#9430 from Mause/c-api-extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Awaiting requested review from Mytherin

Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mause @Mytherin