Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Satisfy GCC's LTO checks #9386

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Satisfy GCC's LTO checks #9386

merged 1 commit into from
Oct 19, 2023

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented Oct 18, 2023

This is necessary for the R package and perhaps later for other static analysis tools.

Follow-up to duckdb/duckdb-r#35.

@krlmlr krlmlr requested a review from hannes October 18, 2023 11:59
@github-actions github-actions bot marked this pull request as draft October 18, 2023 12:00
@krlmlr krlmlr force-pushed the b-minusone branch 3 times, most recently from 07dd1cc to ac57999 Compare October 18, 2023 12:05
@hannes
Copy link
Member

hannes commented Oct 18, 2023 •
edited
Loading

I think we should just remove the -1 like in the linked PR

@krlmlr krlmlr marked this pull request as ready for review October 18, 2023 13:41
@github-actions github-actions bot marked this pull request as draft October 18, 2023 13:42
@krlmlr krlmlr marked this pull request as ready for review October 18, 2023 13:42
Mytherin
Mytherin approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@Mytherin Mytherin merged commit c6b0182 into duckdb:main Oct 19, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Mytherin approved these changes

@hannes hannes Awaiting requested review from hannes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krlmlr @hannes @Mytherin