[Export Database] Produce up-to-date query for ViewCatalogEntry #9375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Perhaps it makes sense to, instead of introducing an extra list of aliases ( |
Mytherin
reviewed
Oct 20, 2023
|
Thanks! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #9367
We regenerate the
sqlwhen ToSQL() is called, this is different from before in that all names are provided as explicit aliases.This is done because name changes of the referenced table is not reflected in the view anyways, so it's fine to just record the names at the time of creation.
This behavior (not letting changes to the referenced query impact the names of the view) is copied from PostgreSQL