Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extention template: Enable DuckDB-Wasm extensions #9356

Merged
merged 7 commits into from
Nov 24, 2023
Merged

Extention template: Enable DuckDB-Wasm extensions #9356

merged 7 commits into from
Nov 24, 2023

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Oct 16, 2023

No description provided.

@Mytherin
Copy link
Collaborator

Mytherin commented Nov 8, 2023

@samansmink could you have a look?

@samansmink
Copy link
Contributor

To review this I would like to have a draft PR from the extension template that shows that this workflow works. Have already discussed this with @carlopi.

@github-actions github-actions bot marked this pull request as draft November 22, 2023 09:44
@carlopi carlopi marked this pull request as ready for review November 22, 2023 16:11
@github-actions github-actions bot marked this pull request as draft November 22, 2023 16:14
@carlopi carlopi marked this pull request as ready for review November 22, 2023 16:18
@carlopi
Copy link
Contributor Author

carlopi commented Nov 22, 2023

Eventual successful run will be here: https://github.com/carlopi/extension-template/actions/runs/6959995349.

This includes an hack to workaround both a limitation of the parsing script AND the fact that in the source code for v0.9.2 wasm target is currently missing.

Hack can be potentially removed at some point, but should not generate any problem, since it's simply checking for file equality ( that meant something is already gone wrong).

@github-actions github-actions bot marked this pull request as draft November 22, 2023 16:29
@carlopi carlopi marked this pull request as ready for review November 22, 2023 16:30
@carlopi
Copy link
Contributor Author

carlopi commented Nov 22, 2023

Successful run (on custom repo) is here: https://github.com/carlopi/extension-template/actions/runs/6959995349

samansmink
samansmink reviewed Nov 23, 2023
View reviewed changes
Copy link
Contributor

@samansmink samansmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, very excited to push for more wasm extensions!

.github/config/distribution_matrix.json Show resolved Hide resolved
@github-actions github-actions bot marked this pull request as draft November 23, 2023 09:36
@carlopi carlopi marked this pull request as ready for review November 23, 2023 09:36
@github-actions github-actions bot marked this pull request as draft November 23, 2023 09:47
@carlopi carlopi marked this pull request as ready for review November 23, 2023 09:58
@github-actions github-actions bot marked this pull request as draft November 23, 2023 12:32
@carlopi carlopi marked this pull request as ready for review November 23, 2023 14:47
@carlopi
Copy link
Contributor Author

carlopi commented Nov 23, 2023

Examples of uses of this:

samansmink
samansmink approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@samansmink samansmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@github-actions github-actions bot marked this pull request as draft November 24, 2023 08:34
@carlopi carlopi marked this pull request as ready for review November 24, 2023 08:43
@carlopi
Copy link
Contributor Author

carlopi commented Nov 24, 2023

Did some more testing, found a minor corner case that lead to even more proper handling of the special case, I think this is ready to be merged.

Tests are not really testing anything here.

@github-actions github-actions bot marked this pull request as draft November 24, 2023 08:50
@carlopi carlopi marked this pull request as ready for review November 24, 2023 08:53
@carlopi
Copy link
Contributor Author

carlopi commented Nov 24, 2023

Even more bikeshedding.

I think this is properly ready and tested.

This was referenced Nov 24, 2023
Merged
Merged
Closed
@Mytherin Mytherin merged commit 6812703 into duckdb:main Nov 24, 2023
39 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 14, 2023
@krlmlr
chore: Update vendored sources to duckdb/duckdb@7524538
11cf909 
Merge pull request duckdb/duckdb#9788 from carlopi/version_info
Merge pull request duckdb/duckdb#9356 from carlopi/extension_template_wasm
Merge pull request duckdb/duckdb#9782 from szarnyasg/freebsd
Merge pull request duckdb/duckdb#9779 from dpprdan/chore/fix_duckdblabs_links
@carlopi carlopi deleted the extension_template_wasm branch January 10, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samansmink samansmink samansmink approved these changes

Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlopi @Mytherin @samansmink