Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension install fixes #9294

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Extension install fixes #9294

merged 2 commits into from
Oct 11, 2023

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Oct 10, 2023

Two independent small fixes:

  • INSTALL name to fetch remote extension even when a file called name exist in the local directory.
  • Avoid the "Are you using a development build?" message when we package a release

@carlopi
Extensions: unqualified names to default to remote extensions
e4c3d50 
Before `INSTALL name` with a file called `name` would select that.
After `INSTALL name` now looks for name.duckdb_extension.gz in the extension repoitory

`INSTALL name.something` or `INSTALL './name' would still imply we intend to use a local file
@carlopi
Extensions: Avoid 'Are you using dev build' message on releases
cf017cc
@github-actions github-actions bot marked this pull request as draft October 10, 2023 14:06
@carlopi carlopi marked this pull request as ready for review October 10, 2023 14:09
samansmink
samansmink approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@samansmink samansmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mytherin Mytherin merged commit 277a09f into duckdb:main Oct 11, 2023
51 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@carlopi carlopi deleted the extensioninstallfixes branch October 16, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samansmink samansmink samansmink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlopi @Mytherin @samansmink