Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify replacement scan filename parsing #9273

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Unify replacement scan filename parsing #9273

merged 5 commits into from
Oct 11, 2023

Conversation

lnkuiper
Copy link
Contributor

@lnkuiper lnkuiper commented Oct 9, 2023

Fixes #8989

We now recognize filename.json.gz as a JSON file when COPY commands are used.

Mytherin
Mytherin reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Could you just have a look at the failing CI?

@github-actions github-actions bot marked this pull request as draft October 10, 2023 08:05
@lnkuiper lnkuiper marked this pull request as ready for review October 10, 2023 08:05
@github-actions github-actions bot marked this pull request as draft October 10, 2023 11:34
@lnkuiper lnkuiper marked this pull request as ready for review October 10, 2023 11:35
@github-actions github-actions bot marked this pull request as draft October 10, 2023 14:06
@Mytherin Mytherin marked this pull request as ready for review October 10, 2023 15:43
@lnkuiper
Copy link
Contributor Author

CI is passing now, the last run had a spurious failure

@Mytherin Mytherin merged commit 8bb1b55 into duckdb:main Oct 11, 2023
50 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@lnkuiper lnkuiper deleted the replacement_scan_gz branch November 24, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Mytherin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

COPY FROM does not recognize json.gz files and treats it as CSV
2 participants
@lnkuiper @Mytherin