Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI: Make it possible to create enum types #8788

Merged
merged 3 commits into from
Nov 9, 2023
Merged

CAPI: Make it possible to create enum types #8788

merged 3 commits into from
Nov 9, 2023

Conversation

alnkesq
Copy link
Contributor

@alnkesq alnkesq commented Sep 4, 2023

The C API was previously able to only create union and struct logical types, but not enums. This PR adds support for enums as well.

Tishj
Tishj approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Mytherin Mytherin changed the base branch from main to feature November 8, 2023 12:43
@github-actions github-actions bot marked this pull request as draft November 8, 2023 12:46
@Mytherin Mytherin marked this pull request as ready for review November 8, 2023 12:47
@Mytherin Mytherin merged commit b1fb71b into duckdb:feature Nov 9, 2023
46 of 47 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Nov 9, 2023

Thanks!

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 11, 2023
@krlmlr
chore: Update vendored sources to duckdb/duckdb@a1ee5f1
488b777 
Merge pull request duckdb/duckdb#9392 from lnkuiper/parquet_encryption
Merge pull request duckdb/duckdb#9461 from hawkfish/merge-sort-trees
Merge pull request duckdb/duckdb#8788 from alnkesq/capi_create_enum_type
Merge pull request duckdb/duckdb#9513 from Tmonster/5614-database-invalidated
Merge pull request duckdb/duckdb#9622 from Mytherin/typescoping
Merge pull request duckdb/duckdb#9615 from hawkfish/strptime-infinity
Merge pull request duckdb/duckdb#9627 from Mytherin/attachifnotexists
Merge pull request duckdb/duckdb#9648 from samansmink/add-keep-alive-toggle
Merge pull request duckdb/duckdb#9638 from taniabogatsch/bench-refactor
Merge pull request duckdb/duckdb#9651 from Mytherin/getenv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tishj Tishj Tishj approved these changes

Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alnkesq @Mytherin @Tishj