Fix python flaky test (potentially GET requests gets back 403) #8074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fail, again, not exactly sure what's the right catch, should be trivial but I don't see it, maybe some pythonista can take this further |
FIXME: find proper way to add this back
|
Actually decided on removing the test on the json, since failing CI is in any case not great, someone / me of the future can than add this back again. |
|
Thanks! Best to leave it out if it is flaky indeed. Perhaps this can be moved to the Linux HTTPFS test suite? |
|
I was taking a look with @Tishj, he found also the second test in that file should be modified to catch a We can check later on how you want to address it / where should this be moved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last few Python CI jobs failed due to this: https://github.com/duckdb/duckdb/actions/workflows/Python.yml.