Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI job to move synchronized PRs to draft #8010

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Jun 20, 2023

Should complement PR #8007 in that PRs will move to being draft, and a subsequent click (when actually ready!) to mark them as ready will have the CI run.
Current setup requires open -> draft -> open, step 1 is now done automatically.

Should complement PR duckdb#8007 in that PRs will move to being draft, and a subsequent click
(when actually ready!) to mark them as ready will have the CI run
Currently requires open -> draft -> open, step 1 is done automatically
@carlopi
Copy link
Contributor Author

carlopi commented Jun 20, 2023

Tested in my fork, seems to work in moving any PR that is being syncronized to being automatically a draft, that makes so that in the web UI for example the button "Ready for review" becomes apparent, in my mind it's slightly easy in cutting a few click here and there and having from the PRs overview a clearer distinction between PRs that are in-flight and PRs that are being worked on.

Obviously also for this only real test is merging and checking whether it actually works.

Copy link
Contributor

@samansmink samansmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I think this is a very natural workflow

@Mytherin Mytherin merged commit fb1f975 into duckdb:master Jun 20, 2023
@Mytherin
Copy link
Collaborator

Great idea, let's see how it works

@carlopi carlopi deleted the autoDraft branch June 21, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants