Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple assignment for UPDATE SET #7968

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

nickgerrets
Copy link
Contributor

Solves #7069

Implemented Transform for the T_MultiAssignRef expression type.

A ParserException is thrown when the left side of the assignment doesn't have an equal amount of columns as the right side of the assignent, i.e:
UPDATE tbl SET (a, b, c) = (1, 2);

Copy link
Contributor

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, the changes here look great, I just had some requests for more tests and improving some error messages.

Copy link
Contributor

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@Mytherin Mytherin changed the base branch from master to feature June 20, 2023 09:42
@Mytherin Mytherin merged commit 16bf4b8 into duckdb:feature Jun 20, 2023
@Mytherin
Copy link
Collaborator

Thanks! Looks great!

@nickgerrets nickgerrets deleted the multi_assign_ref branch June 20, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants