test(nodejs): add test_all_types.test.ts #7740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mause
commented
May 30, 2023
Mause
commented
May 30, 2023
| const all_types = await get_all_types(); | ||
|
|
||
| for (const cur_type of all_types) { | ||
| // FIXME: these currently have too high a precision to be tested |
There was a problem hiding this comment.
Node doesn't have a builtin Decimal class, so while these are returned, the results are way off. Not sure if we should write a simple wrapper around the BigInt class and use that, return them as strings, or just live with the inaccuracy
…re/nodejs-test-all-types
Mause
force-pushed
the
feature/nodejs-test-all-types
branch
from
49f446a
to
e60cda3
Compare
…re/nodejs-test-all-types
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a port from the python test_all_types, with the addition of switching to using the BigInt class for the larger integer types. Worth discussing whether we make this breaking change, or put it behind a setting