-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't create config folder on extension listing #15530
Don't create config folder on extension listing #15530
Conversation
if (!create) { | ||
return extension_directory; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a corner case where extension_directory
exists, and the subdirectories are still created.
Possibly create should wrap all calls of CreateDirectory
(2 locations).
@@ -120,8 +120,8 @@ class ExtensionHelper { | |||
static ExtensionUpdateResult UpdateExtension(ClientContext &context, const string &extension_name); | |||
|
|||
//! Get the extension directory base on the current config | |||
static string ExtensionDirectory(ClientContext &context); | |||
static string ExtensionDirectory(DatabaseInstance &db, FileSystem &fs); | |||
static string ExtensionDirectory(ClientContext &context, bool create = true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity can we add this functionality as a separate method - GetExtensionDirectoryPath
- which only returns the path (i.e. runs the first part of the current ExtensionDirectory
function)? Then ExtensionDirectory
can call that method and do the creation, and we can call GetExtensionDirectoryPath
directly if we do not need to create the directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Thanks! |
Don't create config folder on extension listing (duckdb/duckdb#15530) [Python] Align the behavior between `sql` and `execute` for `.pl()` call (duckdb/duckdb#15537) Update year in license file to 2025 (duckdb/duckdb#15545) [Julia] Improves Julia support for scalar UDFs (duckdb/duckdb#15430)
Don't create config folder on extension listing (duckdb/duckdb#15530) [Python] Align the behavior between `sql` and `execute` for `.pl()` call (duckdb/duckdb#15537) Update year in license file to 2025 (duckdb/duckdb#15545) [Julia] Improves Julia support for scalar UDFs (duckdb/duckdb#15430) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Not sure if this is needed, but whenever extensions are listed if .duckdb folder is not existent it won't be created by default.
Closes: #15471