[CSV Sniffer] Slight change of rules for dialect detection #14013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdet
changed the title
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
[CSV Sniffer] Slight change of rules for dialect detection (duckdb/duckdb#14013) fix minor typos in comments of aggregate function tests (duckdb/duckdb#14007) Disable swift linux tests (duckdb/duckdb#14019)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
[CSV Sniffer] Slight change of rules for dialect detection (duckdb/duckdb#14013) fix minor typos in comments of aggregate function tests (duckdb/duckdb#14007) Disable swift linux tests (duckdb/duckdb#14019) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ignore_errors=true, null_padding = false. we pick the number of columns as the most frequent option.In case of a tie, we pick the higher number.
Fix: #14001