Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C API] Add SQLNULL to the duckdb types #13999

Merged
merged 2 commits into from
Sep 18, 2024
Merged

[C API] Add SQLNULL to the duckdb types #13999

merged 2 commits into from
Sep 18, 2024

Conversation

taniabogatsch
Copy link
Contributor

Without SQLNULL, scalar functions with ANY parameters incorrectly return INVALID as the vector's type or hit the respective assertion.

duckdb_type ConvertCPPTypeToC(const LogicalType &sql_type) {
	switch (sql_type.id()) {
	case LogicalTypeId::INVALID:
...
		return DUCKDB_TYPE_ARRAY;
	case LogicalTypeId::ANY:
		return DUCKDB_TYPE_ANY;
	default: // LCOV_EXCL_START
		D_ASSERT(0);
		return DUCKDB_TYPE_INVALID;
	} // LCOV_EXCL_STOP
}

@duckdb-draftbot duckdb-draftbot marked this pull request as draft September 18, 2024 08:06
@taniabogatsch taniabogatsch marked this pull request as ready for review September 18, 2024 08:06
@taniabogatsch taniabogatsch mentioned this pull request Sep 18, 2024
Merged
@taniabogatsch
Copy link
Contributor Author

The failure is unrelated.

@Mytherin Mytherin merged commit 03976af into duckdb:main Sep 18, 2024
44 of 45 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@taniabogatsch taniabogatsch deleted the sqlnull-in-capi branch September 18, 2024 15:22
Giorgi added a commit to Giorgi/DuckDB.NET that referenced this pull request Sep 22, 2024
@Giorgi
Add SQLNULL Type
90d9180 
duckdb/duckdb#13999
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Sep 27, 2024
@krlmlr
chore: Update vendored sources to duckdb/duckdb@03976af
e721a8a 
[C API] Add SQLNULL to the duckdb types (duckdb/duckdb#13999)
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Sep 27, 2024
@github-actions @krlmlr
chore: Update vendored sources to duckdb/duckdb@03976af (#435)
0c89e28 
[C API] Add SQLNULL to the duckdb types (duckdb/duckdb#13999)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samansmink samansmink Awaiting requested review from samansmink

Assignees
No one assigned
Labels
Ready For Review Ready To Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taniabogatsch @Mytherin