Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify create_art_varchar.benchmark so it passes weekly regressions #13968

Merged

Conversation

Tmonster
Copy link
Contributor

@Tmonster Tmonster commented Sep 16, 2024

Currently the benchmark causes the weekly regressions to fail due to a timeout.

With these changes the benchmark passes.

(This issue)[https://github.com/duckdblabs/duckdb-internal/issues/2855] explains that the benchmark now takes ~2x as long, so I changed range(7200000) to range(3600000)

@Mytherin Mytherin merged commit f759410 into duckdb:main Sep 16, 2024
39 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Sep 26, 2024
Fix data race when writing GeoParquet (duckdb/duckdb#13962)
Modify create_art_varchar.benchmark so it passes weekly regressions (duckdb/duckdb#13968)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Sep 26, 2024
Fix data race when writing GeoParquet (duckdb/duckdb#13962)
Modify create_art_varchar.benchmark so it passes weekly regressions (duckdb/duckdb#13968)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants