Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12215: AsOf Predicate Pushdown #12238

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

hawkfish
Copy link
Contributor

Don't split conditions that are not AsOf comparisons.

fixes: #12215
fixes: duckdblabs/duckdb-internal#2124

Don't split conditions that are not AsOf comparisons.

fixes: duckdb#12215
fixes: duckdblabs/duckdb-internal#2124
@hawkfish hawkfish requested a review from Mytherin May 24, 2024 20:49
@hawkfish
Copy link
Contributor Author

Seems like a correctness issue but I can rebase to feature if not.

@Mytherin Mytherin merged commit 8a34c96 into duckdb:main May 25, 2024
41 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@hawkfish hawkfish deleted the asof-pushdown branch May 28, 2024 18:12
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jun 5, 2024
Merge pull request duckdb/duckdb#12238 from hawkfish/asof-pushdown
Merge pull request duckdb/duckdb#12236 from carlopi/macosmin12
Merge pull request duckdb/duckdb#12229 from carlopi/cleanup_workflows
Merge pull request duckdb/duckdb#12224 from Tishj/python_disable_replacement_scan
Merge pull request duckdb/duckdb#12106 from Tishj/generic_new_micro_benchmark_check
Merge pull request duckdb/duckdb#12208 from Tishj/python_fix_replacement_scan_hiding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

predicate incorrectly pushed into ASOF JOIN
2 participants