Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing old code that used to check if a buffer was the last buffer from the file handler #11846

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

pdet
Copy link
Contributor

@pdet pdet commented Apr 26, 2024

It's no longer necessary since Next() already returns whether the buffer was the last one.

Fix: #11828

@Mytherin Mytherin merged commit fbd11d6 into duckdb:main Apr 29, 2024
45 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request May 5, 2024
@pdet pdet deleted the compression_oom branch June 25, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Larger-than-memory read_csv throws unnecessary OOM with compression='none' parameter
2 participants