Use ToSQLString() in ConstantFilter for escaped filter output
#11797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Thanks! Looks like there are still some CI failures remaining, could you have a look? |
|
Thanks @Mytherin, I think I have it sorted now. Sorry for the slow response, I wasn't able to get back to this yesterday. (I think I hit 'ready for review' to fire off the CI jobs? Let's see what happens...) |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
May 5, 2024
Merge pull request duckdb/duckdb#11797 from rcurtin/constant-sql-string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (very simple) PR to address #11729.
Output after the change:
(Previously, the output was
Filters: s=hello AND s IS NOT NULL)I don't have the internal knowledge of DuckDB to say whether or not anything is built on top of the assumption that
ConstantFilterdoes not escape string/timestamp constants (or other types), but it at least seems safe to me. Someone much more knowledgeable will have to say.