Reconstruct Error Messages for Flush Cast #11736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! LGTM |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
May 5, 2024
Merge pull request duckdb/duckdb#11736 from pdet/flush_rejects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Depends on: #11733
Cast error messages from the Flush method are a bit brittle since we do not get sufficient information from the vector casting methods.
To resolve #11734 I'm basically reconstructing the error message. I think going forward the idea is to have Decimal Casting directly from the CSV File as well, since that's quite a common type, and then Flush will only be used for nested types and exoteric stuff like hugeints.