[Map] Rework MAP creation method behavior when input is NULL
#11730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishj
commented
Apr 19, 2024
|
It seems in the pandas analyzer we already didn't use this NULL_KEY_LIST invalid-reason because it got converted to a STRUCT instead def test_map_nullkeylist(self, pandas, duckdb_cursor):
x = pandas.DataFrame([[{'key': None, 'value': None}]])
# Isn't actually converted to MAP because isinstance(None, list) != True
converted_col = duckdb_cursor.sql("select * from x").df()
duckdb_col = duckdb_cursor.sql("SELECT {key: NULL, value: NULL} as '0'").df()
pandas.testing.assert_frame_equal(duckdb_col, converted_col)Perhaps we want to change this to also created a NULL MAP
This would relax the last requirement to be:
|
1 task
|
What should |
Different PR, I'll push that when this is merged as it depends on this |
|
Thanks! LGTM |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
May 5, 2024
Merge pull request duckdb/duckdb#11730 from Tishj/map_null_behavior_rework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #11115
Old behavior:
MAP(NULL, [1,2,3])-> Error: Only LIST types are accepted argumentsMAP([1,2,3], NULL)-> Error: Only LIST types are accepted argumentsMAP(NULL, NULL)->{}(empty map)MAP(NULL::INT[], [1,2,3])-> Error: Key list can not be NULLMAP([1,2,3], NULL::INT[])-> Error: Value list can not be NULLMAP(NULL::INT[], NULL::INT[])-> Error: Key list can not be NULLNew behavior:
MAP(NULL, [1,2,3])->NULLMAP([1,2,3], NULL)->NULLMAP(NULL, NULL)->NULLMAP(NULL::INT[], [1,2,3])->NULLMAP([1,2,3], NULL::INT[])->NULLMAP(NULL::INT[], NULL::INT[])->NULL