Fix #11294 - avoid applying Filter Pushdown optimization for UNION/EXCEPT without ALL #11315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ION/EXCEPT without ALL
1 task
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 28, 2024
Merge pull request duckdb/duckdb#11315 from Mytherin/issue11294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11294
Fixes #11163
This was a regression introduced by an internal change in how
UNION/EXCEPTwithoutALLwere planned. Previously an explicitLogicalDistinctwould be pushed into the plan, but after the change theLogicalSetOperationwould instead store this information internally. The filter pushdown optimizer was not correctly adjusted for the new operator causing it to always assume the set operation was of theUNION ALL/EXCEPT ALLvariant - which caused an incorrect plan to be constructed.