Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null pointer exception when rolling back updates if the rollback was caused by an OOM #11309

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

Mytherin
Copy link
Collaborator

If a large update triggers an allocation failure/OOM, it is possible that we write an entry into the transaction log for a specific update, but never actually create that entry. In that case a null pointer exception would be triggered during the rollback, which assumed that the version info for the vector would have been present. This PR modifies the assertion into an actual check, and simply skips the clean-up in this scenario.

@Mytherin Mytherin merged commit 8a7e07b into duckdb:main Mar 23, 2024
44 checks passed
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 28, 2024
Merge pull request duckdb/duckdb#11309 from Mytherin/updatenullrefrollback
@Mytherin Mytherin deleted the updatenullrefrollback branch June 7, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant