Ignore user defined parameters that change names or types of csv columns in sniffer's prompt. #11257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 20, 2024
Merge pull request duckdb/duckdb#11257 from pdet/sniff_csv_ignore Merge pull request duckdb/duckdb#11256 from szarnyasg/README-update Merge pull request duckdb/duckdb#11242 from maiadegraaf/verify_vector_map
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 23, 2024
Merge pull request duckdb/duckdb#11257 from pdet/sniff_csv_ignore Merge pull request duckdb/duckdb#11256 from szarnyasg/README-update Merge pull request duckdb/duckdb#11242 from maiadegraaf/verify_vector_map
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 28, 2024
Merge pull request duckdb/duckdb#11257 from pdet/sniff_csv_ignore Merge pull request duckdb/duckdb#11256 from szarnyasg/README-update Merge pull request duckdb/duckdb#11242 from maiadegraaf/verify_vector_map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these are already defined in the
columnsoption from the prompt, they have no added value.We then ignore all of the following options
column_types
types
dtypes
auto_detect
auto_type_candidates
columns
names