Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE2 upgrade to version 2023-02-01 #11252

Merged
merged 10 commits into from
Mar 26, 2024
Merged

RE2 upgrade to version 2023-02-01 #11252

merged 10 commits into from
Mar 26, 2024

Conversation

hannes
Copy link
Member

@hannes hannes commented Mar 19, 2024

and other fixes related to compiling with C++ 20

fixes #11226

@github-actions github-actions bot marked this pull request as draft March 19, 2024 14:43
@github-actions github-actions bot marked this pull request as draft March 20, 2024 09:19
@hannes hannes marked this pull request as ready for review March 22, 2024 11:27
@github-actions github-actions bot marked this pull request as draft March 22, 2024 16:17
@hannes hannes marked this pull request as ready for review March 22, 2024 16:17
@hannes
Copy link
Member Author

hannes commented Mar 22, 2024

Screenshot 2024-03-22 at 17 18 36

@github-actions github-actions bot marked this pull request as draft March 25, 2024 11:31
@hannes hannes marked this pull request as ready for review March 25, 2024 11:36
@github-actions github-actions bot marked this pull request as draft March 25, 2024 15:21
@hannes hannes marked this pull request as ready for review March 25, 2024 15:21
@hannes hannes merged commit ecfe102 into duckdb:main Mar 26, 2024
49 checks passed
@hannes hannes deleted the re2upgrade branch March 26, 2024 14:17
@krlmlr
Copy link
Collaborator

krlmlr commented Mar 29, 2024

This now breaks the R build because abort() is called: https://github.com/duckdb/duckdb-r/actions/runs/8477680900/job/23228959909#step:9:162 .

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Mar 30, 2024
Merge pull request duckdb/duckdb#11252 from hannes/re2upgrade
Merge pull request duckdb/duckdb#11355 from szarnyasg/remove-issue-labeling-workflow
Merge pull request duckdb/duckdb#11342 from carlopi/fix_staged_releases
Merge pull request duckdb/duckdb#11341 from szarnyasg/iss11339
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 30, 2024
Merge pull request duckdb/duckdb#11252 from hannes/re2upgrade
Merge pull request duckdb/duckdb#11355 from szarnyasg/remove-issue-labeling-workflow
Merge pull request duckdb/duckdb#11342 from carlopi/fix_staged_releases
Merge pull request duckdb/duckdb#11341 from szarnyasg/iss11339
@hannes
Copy link
Member Author

hannes commented Apr 2, 2024

Will send a follow up PR removing the abort then

@hannes
Copy link
Member Author

hannes commented Apr 2, 2024

#11458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation fails in "third_party/re2/re2/walker-inl.h:125" WalkState<T> (C++20, GCC 11/Ubuntu 20.04 x64)
2 participants