Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Correctly revert global storage when aborting index flush #11173

Closed
wants to merge 3 commits into from
Closed

[Fix] Correctly revert global storage when aborting index flush #11173

wants to merge 3 commits into from

Conversation

taniabogatsch
Copy link
Contributor

The relevant changes are highlighted below. @Mytherin, as we discussed, RevertAppendInternal did not revert the append correctly, i.e., we would later append after the reverted changes. Calling FinalizeAppend after RevertAppendInternal seems to fix this.

Before.

	if (append_to_table) {
		table.RevertAppendInternal(append_state.row_start);
	}

Now.

	if (append_to_table) {
		table.RevertAppendInternal(append_state.row_start);
		table.FinalizeAppend(transaction, append_state);
	}

@Mytherin Mytherin mentioned this pull request Mar 15, 2024
Merged
@taniabogatsch taniabogatsch deleted the idx-tx-abort-fix branch March 18, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taniabogatsch