[Python][Arrow] Don't deduplicate column names when outputting to Arrow #11160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in one place, but doing it in another, causing a schema mismatch in the produced arrow table
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 17, 2024
Merge pull request duckdb/duckdb#11161 from Maxxen/bugfixes Merge pull request duckdb/duckdb#11160 from Tishj/dont_deduplicate_arrow_columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #11157
This problem was likely introduced in #10532
When outputting to PyArrow, we create batches and then create a table from those batches.
When creating the batches we were deduplicating column names, but didn't do this for the schema passed to the table-from-batches function.
We properly skip deduplicating in both places now, Arrow has no problem with duplicate column names.