Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Code Quality - PEP8 Compliant + only relevant imports #11070

Merged
merged 1 commit into from
Mar 10, 2024
Merged

[Python] Code Quality - PEP8 Compliant + only relevant imports #11070

merged 1 commit into from
Mar 10, 2024
+41 −45

Conversation

mariotaddeucci
Copy link
Contributor

@mariotaddeucci mariotaddeucci commented Mar 9, 2024 •
edited
Loading

  • Remove unused python standard modules from files
  • Keep imports on top of file when it's possible
  • Add missing typing ColumnOrName on some spark module file
  • Applie PEP8 good practices to core module
    • Avoid bare exception on pandas module check
    • Avoid checking equality on None (using is instead of ==)

Tishj
Tishj approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up 👍

@mariotaddeucci mariotaddeucci marked this pull request as draft March 9, 2024 17:59
@mariotaddeucci mariotaddeucci marked this pull request as ready for review March 9, 2024 17:59
@Mytherin Mytherin merged commit 0457f72 into duckdb:main Mar 10, 2024
26 of 27 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 17, 2024
@krlmlr
chore: Update vendored sources to duckdb/duckdb@64d1834
09ec6c6 
Merge pull request duckdb/duckdb#11072 from Mytherin/parquetprogress
Merge pull request duckdb/duckdb#10707 from Mause/bugfix/jdbc-get-time
Merge pull request duckdb/duckdb#10831 from krlmlr/f-ext-patch
Merge pull request duckdb/duckdb#11070 from mariotaddeucci/code-quality-pep8-compliant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tishj Tishj Tishj approved these changes

@Mause Mause Mause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariotaddeucci @Mytherin @Mause @Tishj