Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add concat_ws to spark API #11051

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

nicornk
Copy link
Contributor

@nicornk nicornk commented Mar 8, 2024

As per discussion here
#11044

Copy link
Contributor

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks excellent!
I think this is ready to merge when CI passes

@nicornk nicornk force-pushed the contribute_spark_concat_ws branch from 3be15a0 to d3e514c Compare March 8, 2024 09:42
@github-actions github-actions bot marked this pull request as draft March 8, 2024 09:43
@nicornk nicornk marked this pull request as ready for review March 8, 2024 09:43
@nicornk
Copy link
Contributor Author

nicornk commented Mar 8, 2024

Force pushed with proper formatting @Tishj

@Mytherin Mytherin merged commit 1816efe into duckdb:main Mar 8, 2024
15 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Mar 8, 2024

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 16, 2024
Merge pull request duckdb/duckdb#11031 from Mause/feature/jdbc-comments
Merge pull request duckdb/duckdb#11051 from nicornk/contribute_spark_concat_ws
Merge pull request duckdb/duckdb#11052 from tcldr/duckdb-swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants