Fix #10982 - only update total rows of row group collection after we finish appending to prevent other readers from attempting to initialize scans on in-progress appends #11011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er we finish appending to prevent other readers from attempting to initialize scans on in-progress appends
1 task
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 16, 2024
Merge pull request duckdb/duckdb#11011 from Mytherin/concurrenttableinsertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10982
This was an issue that could sporadically happen if multiple connections were concurrently writing and reading from the same table. Essentially we updated the total number of rows in the table before adding the column segments containing the data - which could then lead to an exception being thrown when reading as another connection would try to read until
total_rows, but could not find the column segment belonging to those rows.