Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize dynamic cast check and disable on MacOS #10925

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Mytherin
Copy link
Collaborator

Fixes an issue described here - #6521 (comment)

When developing extensions on MacOS the dynamic assertions do not work correctly due to the RTTI issue described in the thread. As this is just an assertion we just disable it on MacOS.

@Mytherin Mytherin merged commit 6634735 into duckdb:main Feb 29, 2024
43 checks passed
@carlopi
Copy link
Contributor

carlopi commented Feb 29, 2024

LGTM, thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 16, 2024
Merge pull request duckdb/duckdb#10925 from Mytherin/dynamiccastcheck
@Mytherin Mytherin deleted the dynamiccastcheck branch July 5, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants