Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if directory exists before removing files in regression test runner #10859

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

Tmonster
Copy link
Contributor

The Weekly regression runs the regression test runner not in a duckdb directory. The addition of shuttle.rmtree('ducdkb_benchmark_data') caused the regression test to fail because of this.

Now we just check and make sure it is a directory before removing the data. That way the weekly regression runner won't fail.

@Mytherin Mytherin merged commit a2cc6bb into duckdb:main Feb 27, 2024
41 checks passed
@Mytherin
Copy link
Collaborator

Thanks! LGTM

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 15, 2024
Merge pull request duckdb/duckdb#10597 from Tishj/extension_function_type_listing
Merge pull request duckdb/duckdb#10859 from Tmonster/remove_sh_util_rm_dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants