[CSV Reader] Also use figure-out-line code when ignoring errors. (#14184

) Fix: #14177
duckdb · Oct 7, 2024 · 123b82b · 123b82b
2 parents 405e15f + 18358b5
commit 123b82b
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 4 deletions.
diff --git a/data/csv/auto/14177.csv b/data/csv/auto/14177.csv
@@ -0,0 +1,14 @@
+"id","description"
+"1","This is a test description for id 1"
+"2","This is a test description,
+This is a
+longer description for id 2"
+"3","This is a test description,
+This is a
+longer description for id 3"
+"4","This is a test description,
+This is a
+longer description for id 4"
+"5","This is a test description,
+This is a
+longer description for id 5"
diff --git a/src/execution/operator/csv_scanner/scanner/string_value_scanner.cpp b/src/execution/operator/csv_scanner/scanner/string_value_scanner.cpp
@@ -1470,10 +1470,6 @@ void StringValueScanner::SetStart() {
 		}
 		return;
 	}
-	if (state_machine->options.IgnoreErrors()) {
-		// If we are ignoring errors we don't really need to figure out a line.
-		return;
-	}
 	// The result size of the data after skipping the row is one line
 	// We have to look for a new line that fits our schema
 	// 1. We walk until the next new line

diff --git a/test/sql/copy/csv/auto/test_14177.test b/test/sql/copy/csv/auto/test_14177.test
@@ -0,0 +1,11 @@
+# name: test/sql/copy/csv/auto/test_14177.test
+# description: Test CSV Sample works for #14177
+# group: [auto]
+
+statement ok
+PRAGMA enable_verification
+
+query I
+select count(*) FROM (FROM read_csv('data/csv/auto/14177.csv', buffer_size=80, ignore_errors = true)) as t
+----
+5