Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP secret extra_http_headers #456

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

dvic
Copy link
Contributor

@dvic dvic commented Oct 8, 2024

To support secrets like:

CREATE SECRET http (
    TYPE HTTP,
    EXTRA_HTTP_HEADERS MAP {
        'Authorization': 'Bearer sk_test_VePHdqKTYQjKNInc7u56JBrQ'
    }
); 

select unnest(data) as customers 
from read_json('https://api.stripe.com/v1/customers');

source:
https://duckdbsnippets.com/snippets/184/query-an-authenticated-api-endpoint

@jwills
Copy link
Collaborator

jwills commented Oct 10, 2024

@dvic Change looks good to me, thanks for calling it out! There is a linting issue but I'll fix it separately on main

@jwills jwills merged commit db95b91 into duckdb:master Oct 10, 2024
30 of 31 checks passed
jwills added a commit that referenced this pull request Oct 10, 2024
jwills added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants