Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to dbt-common + dbt-adapters for v1.8+ #341

Closed
jtcohen6 opened this issue Feb 19, 2024 · 0 comments · Fixed by #342
Closed

Migrate to dbt-common + dbt-adapters for v1.8+ #341

jtcohen6 opened this issue Feb 19, 2024 · 0 comments · Fixed by #342

Comments

@jtcohen6
Copy link
Contributor

Discussion:

tl;dr: Starting with dbt-core v1.8, adapters should no longer import dbt-core directly, but instead import a set of common interfaces defined in dbt-common + dbt-adapters.

I wanted to give this one a try :)

It's mostly a matter of switching import statements. I found two utility classes — SourceConfig and TargetConfig — which depend on type definitions (RuntimeConfigObject, SourceDefinition) that are not included in our common/adapter interface. I'll open a draft PR so we can take a look together & discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant