Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed GitVersion.yml feature and fix Regex - Fixes #660 #661

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Fixed GitVersion.yml feature and fix Regex - Fixes #660 #661

merged 1 commit into from
Jan 7, 2020

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jan 7, 2020 •
edited
Loading

Pull Request (PR) description

Fixed GitVersion.yml feature and fix Regex

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

@johlju - would you mind reviewing for me?

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jan 7, 2020
johlju
johlju approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit d002c9a into dsccommunity:master Jan 7, 2020
@johlju johlju removed the needs review The pull request needs a code review. label Jan 7, 2020
@PlagueHO PlagueHO deleted the Issue-660 branch January 8, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update GitVersion Fix Regex
2 participants
@PlagueHO @johlju