Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate in favor of rack-attack #51

Merged
merged 5 commits into from
Mar 1, 2023

Conversation

FreekingDean
Copy link
Collaborator

@FreekingDean FreekingDean commented Oct 2, 2019

This is a really large conceptual PR so I'm going to let this sit for a while to gather feedback!

RackAttack has much more active maintenance & is more mature. I believe we should nudge those looking to do rate limiting in rack apps that way to be the most helpful we can be!
Fixes #43
Fixes #55

@FreekingDean
Copy link
Collaborator Author

@gkellogg I noticed a few dependency updates from you & dependabot. I was wondering if you wanted to chime in here?

@artob as well, but I know you have been away from open source stuffs lately :)

@gkellogg
Copy link

@FreekingDean I don't really have an opinion; dependency updates would be due to the RDF.rb 3.1 release and dropping support for older Ruby versions, and of course versions of Rack < 2.0.

I think the way to probably handle it is to do necessary updates to make this gem current, and add a [DEPRECATION] warning that points people to RackAttack and that this gem is now deprecated and will not receive any substantial updates. [DEPRECATION] probably needs to go in the gemspec post_install_message and all of the initialize methods for each module.

As the author and only person who can update RubyGems, @artob would need to either add an owner to the library (preferable) or do the push to RubyGems for whatever comes out of this.

I see it's used by 236 different repos, although the gem spec looks pretty old.

See https://github.com/ruby-rdf/rack-linkeddata/blob/develop/rack-linkeddata.gemspec for something that would be compatible with where we are with Ruby RDF.

@FreekingDean
Copy link
Collaborator Author

FreekingDean commented Dec 18, 2019 via email

Copy link
Contributor

@sandstrom sandstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a very sound adjustment. 👍🏻 on the merge

Just one data point, but I found this quickly, but didn't notice rack-attack until quite a while later.

README.md Outdated Show resolved Hide resolved
lib/rack/throttle/limiter.rb Outdated Show resolved Hide resolved
rack-throttle.gemspec Outdated Show resolved Hide resolved
@FreekingDean
Copy link
Collaborator Author

FreekingDean commented Sep 25, 2020 via email

@joshbuker
Copy link

@dryruby @FreekingDean any movement on this? This would help save some time for developers looking into rate limiting for rack-based applications.

Co-authored-by: sandstrom <mail+github@a16m.se>
@FreekingDean FreekingDean merged commit 9aa81a6 into dryruby:master Mar 1, 2023
@FreekingDean FreekingDean deleted the chore/depreacte branch March 1, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

README in latest release & tagging Deprecate in favor of RackAttack
4 participants