suppress the unused_unsafe lint in macro code #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if you used any of the macros inside an unsafe block of your own, the compiler would complain that you were unnecessarily nesting unsafe blocks.
|
Hmmm. This isn't a very active project, but I'd tend to assume that people are using a pretty recent stable version. If not, they could always pin at an older version of arrayref. |
|
Is there anything I can clean up, or should we land it as is? |
|
Looks fine, it just kept getting procrastinated. |
|
Would you like me to do a version bump just for this? |
|
I've already worked around it in my own code, so no rush. Maybe if nothing else comes in for a month or two? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you used any of the macros inside an unsafe block of your own, the compiler would complain that you were unnecessarily nesting unsafe blocks.
I'm not sure what version of the Rust compiler stabilized block level attributes, though, so it's possible this bumps the minimum compiler version. What's the project policy on that sort of thing?