Initial attempt at building/testing/publishing under linux #196

connorworley · 2020-12-23T03:07:28Z

Checklist

General Contributing

Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

Non-code related change (markdown/git settings etc)
SDK Code Change
Example/Test Code Change

Validation

Does this code build successfully?
Do all tests pass?
Does Stylecop pass?

This is my first attempt at getting the workflow for this SDK fully running on Linux. There are several changes.

.NET Framework 4.5 support is dropped in favor of solely targeting .NET Standard 2.0.
CI now runs on ~~both Windows and~~ Linux.
Publishing now runs on Linux.
The version number has been removed from the repo. GitHub Actions will publish with whatever number is used when a new release is created.
A few .csproj files have been rewritten. These files contained a lot of VS cruft that we don't care about if we're developing on Linux.
A few scripts have been changed.
The generator Python scripts have been automatically upgraded for Python 3 compatibility.
Unit tests now generate code coverage reports.

codecov · 2020-12-23T08:31:39Z

Codecov Report

❗ No coverage uploaded for pull request base (main@de96458). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage        ?   10.99%           
=======================================
  Files           ?       14           
  Lines           ?     1428           
  Branches        ?        0           
=======================================
  Hits            ?      157           
  Misses          ?     1271           
  Partials        ?        0

Flag	Coverage Δ
unit	`10.99% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de96458...cc42447. Read the comment docs.

.github/workflows/ci.yml

rogebrd · 2020-12-23T21:00:20Z

dropbox-sdk-dotnet/Dropbox.Api.Integration.Tests/Dropbox.Api.Integration.Tests.csproj

-    <IsCodedUITest>False</IsCodedUITest>
-    <TestProjectType>UnitTest</TestProjectType>
-    <TargetFrameworkProfile />
+    <TargetFramework>net5.0</TargetFramework>


I thought we planned to support netstandard2.0? Is there a reason we want this on net5.0? I believe net is just the .NET Framework or is it .NET Core?

This is .NET Core, the naming is weird for 5 onwards. I ran into issues with setting up the tests when targeting the standard and figure targeting a specific core version is fine since this is a dev-only change.

generator/run_this.py

scripts/generate_stone.ps1

.github/workflows/ci.yml

dropbox-sdk-dotnet/Dropbox.Api.Integration.Tests/Dropbox.Api.Integration.Tests.csproj

rogebrd · 2020-12-23T21:08:57Z

dropbox-sdk-dotnet/Dropbox.Api.Integration.Tests/Dropbox.Api.Integration.Tests.csproj

  <ItemGroup>
-    <None Include="dropbox.runsettings" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.7.1" />


Do we need to specify that this csproj is for tests? Or does it know based on these imports? I see above line 18 is where we specified it before but not sure if that is still needed

I think the thing in the old file was just a hint for the IDE? I can add it back, but in theory we can dotnet test any of these csproj files without any extra metadata.

dropbox-sdk-dotnet/Dropbox.Api/Dropbox.Api.csproj

generator/csharp.py

rogebrd

Looks all good to me! Glad to see were cleaning up a lot of the code

* #193 Fix InvalidCastException 1. Turn off DateTime parsing by JsonTextReader 2. Perform parsing in DateTimeDecoder using the same Culture and DateTimeKind. 3. Added tests to verify the behavior. * Initial attempt at building/testing/publishing under linux (#196) * Initial attempt at building/testing/publishing under linux * replace backslash with forwardslash * Attempt to add unit test coverage reports * try to fix gh actions syntax error * try to fix gh actions syntax error again * try to fix conditional expression for publishing coverage * try to fix conditional expression for publishing coverage again * only run CI on ubuntu * PR feedback * no multi-line run directives on windows Co-authored-by: Connor Worley <cworley@dropbox.com> * Bump peter-evans/create-pull-request from v3.4.1 to v3.6.0 (#198) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from v3.4.1 to v3.6.0. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v3.4.1...45c510e) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-python from v2.1.4 to v2.2.1 (#195) Bumps [actions/setup-python](https://github.com/actions/setup-python) from v2.1.4 to v2.2.1. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v2.1.4...3105fb1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump codecov/codecov-action from v1.0.15 to v1.1.1 (#201) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.0.15 to v1.1.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v1.0.15...1fc7722) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * #193 Fix InvalidCastException 1. Turn off DateTime parsing by JsonTextReader 2. Perform parsing in DateTimeDecoder using the same Culture and DateTimeKind. 3. Added tests to verify the behavior. Co-authored-by: Connor Worley <connorbworley@gmail.com> Co-authored-by: Connor Worley <cworley@dropbox.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Initial attempt at building/testing/publishing under linux * replace backslash with forwardslash * Attempt to add unit test coverage reports * try to fix gh actions syntax error * try to fix gh actions syntax error again * try to fix conditional expression for publishing coverage * try to fix conditional expression for publishing coverage again * only run CI on ubuntu * PR feedback * no multi-line run directives on windows Co-authored-by: Connor Worley <cworley@dropbox.com>

* #193 Fix InvalidCastException 1. Turn off DateTime parsing by JsonTextReader 2. Perform parsing in DateTimeDecoder using the same Culture and DateTimeKind. 3. Added tests to verify the behavior. * Initial attempt at building/testing/publishing under linux (#196) * Initial attempt at building/testing/publishing under linux * replace backslash with forwardslash * Attempt to add unit test coverage reports * try to fix gh actions syntax error * try to fix gh actions syntax error again * try to fix conditional expression for publishing coverage * try to fix conditional expression for publishing coverage again * only run CI on ubuntu * PR feedback * no multi-line run directives on windows Co-authored-by: Connor Worley <cworley@dropbox.com> * Bump peter-evans/create-pull-request from v3.4.1 to v3.6.0 (#198) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from v3.4.1 to v3.6.0. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v3.4.1...45c510e) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-python from v2.1.4 to v2.2.1 (#195) Bumps [actions/setup-python](https://github.com/actions/setup-python) from v2.1.4 to v2.2.1. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v2.1.4...3105fb1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump codecov/codecov-action from v1.0.15 to v1.1.1 (#201) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.0.15 to v1.1.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v1.0.15...1fc7722) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * #193 Fix InvalidCastException 1. Turn off DateTime parsing by JsonTextReader 2. Perform parsing in DateTimeDecoder using the same Culture and DateTimeKind. 3. Added tests to verify the behavior. Co-authored-by: Connor Worley <connorbworley@gmail.com> Co-authored-by: Connor Worley <cworley@dropbox.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Connor Worley added 8 commits December 23, 2020 02:58

Initial attempt at building/testing/publishing under linux

b493a87

replace backslash with forwardslash

228d3a8

Attempt to add unit test coverage reports

a6e1176

try to fix gh actions syntax error

e19b38e

try to fix gh actions syntax error again

443bcea

try to fix conditional expression for publishing coverage

d0b5a49

try to fix conditional expression for publishing coverage again

5758c83

only run CI on ubuntu

233676a

rogebrd reviewed Dec 23, 2020

View reviewed changes

Connor Worley added 2 commits December 23, 2020 16:11

PR feedback

93a016b

no multi-line run directives on windows

cc42447

connorworley requested a review from rogebrd December 24, 2020 00:27

connorworley mentioned this pull request Dec 24, 2020

#193 Fix InvalidCastException #197

Merged

7 tasks

rogebrd approved these changes Dec 28, 2020

View reviewed changes

connorworley merged commit 02beced into main Dec 28, 2020

connorworley deleted the linux_build branch December 28, 2020 21:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial attempt at building/testing/publishing under linux #196

Initial attempt at building/testing/publishing under linux #196

connorworley commented Dec 23, 2020 •

edited

Loading

codecov bot commented Dec 23, 2020 •

edited

Loading

rogebrd Dec 23, 2020

connorworley Dec 23, 2020

rogebrd Dec 23, 2020

connorworley Dec 23, 2020

rogebrd left a comment

Initial attempt at building/testing/publishing under linux #196

Initial attempt at building/testing/publishing under linux #196

Conversation

connorworley commented Dec 23, 2020 • edited Loading

Checklist

codecov bot commented Dec 23, 2020 • edited Loading

Codecov Report

rogebrd Dec 23, 2020

Choose a reason for hiding this comment

connorworley Dec 23, 2020

Choose a reason for hiding this comment

rogebrd Dec 23, 2020

Choose a reason for hiding this comment

connorworley Dec 23, 2020

Choose a reason for hiding this comment

rogebrd left a comment

Choose a reason for hiding this comment

connorworley commented Dec 23, 2020 •

edited

Loading

codecov bot commented Dec 23, 2020 •

edited

Loading