Adjust reading binning, to allocate readings to the previous time interval #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the 1 hour bins for the power consumption, the reading from full hours e.g. 9:00 is put into the bin of 9:00 - 10:00.
However, the reading represents the consumption of 8:45 - 9:00, it should be actually part of the 8:00 - 9:00 bin.
(likewise if processing daily readings, I guess they are reported at midnight, and thus would fall into the following day)
As an easy solution, I moved back the timestamps by 1 second. This allows the binning code to be unchanged, still putting the consumption values of full hours into the correct bin.