GCS: improve mime-type detection #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 32 32
Lines 5379 5379
=======================================
Hits 5343 5343
Misses 19 19
Partials 17 17 Continue to review full report at Codecov.
|
Closed
|
Thank you |
|
Hello @thomas-advantitge thank you again for this contribution. We have recently updated our contribution policy and we now require signing a CLA. Agreeing to the CLA clarifies your rights as a contributor and at the same time protects SFTPGo and its users. More details here You can use the following URL to sign the CLA https://cla-assistant.io/drakkan/sftpgo?pullRequest=179 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @drakkan in #178, better mime type detection than used in the google-cloud-go underlying package.
Example which previously gave
application/zipas mime type: