Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Expand "Modify bin dirs" rule #353

Merged
merged 2 commits into from
Apr 13, 2018
Merged

Fix/Expand "Modify bin dirs" rule #353

merged 2 commits into from
Apr 13, 2018

Conversation

mattpag
Copy link
Contributor

@mattpag mattpag commented Apr 12, 2018

  • To monitor file/dirs removed with unlinkat we need to check evt.abspath, not evt.arg[1]
  • Monitor renameat too

@mattpag mattpag requested a review from mstemm April 12, 2018 12:55
@mattpag mattpag force-pushed the fix_modify_bin_dirs branch from 8fbfffe to a9696ee Compare April 12, 2018 12:56
mstemm
mstemm approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I'm going to merge now as I have some other pending rules cleanups.

@mstemm mstemm merged commit 96b4ff0 into dev Apr 13, 2018
@mstemm mstemm deleted the fix_modify_bin_dirs branch April 13, 2018 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstemm mstemm mstemm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattpag @mstemm