Rule updates 2018 02.v1 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are related to node.js apps.
vRA7 Guest Agent writes to GuestAgent.log with a cwd of root.
All seen in legitimate cases.
Possibly seen as a part of consul deployments and/or openresty.
mattpag
reviewed
Feb 9, 2018
There was a problem hiding this comment.
There's an inconsistency between the comment and the implementation for the macro allowed_ssh_hosts: I suppose you want to set it to ssh_port (as the comment says), otherwise the rule will trigger for every non local ssh connection. Or am I missing something?
The rule for detecting nodeport connections looks good.
New rule "Disallowed SSH Connection" detects ssh connection attempts other than those allowed by the macro allowed_ssh_hosts. The default version of the macro allows any ssh connection, so the rule never triggers by default. The macro could be overridden in a local/user rules file, though.
New rule "Unexpected K8s NodePort Connection" detects attempts to contact K8s NodePort services (i.e. ports >=30000) from within containers. It requires overridding a macro nodeport_containers which specifies a set of containers that are allowed to use these port ranges. By default every container is allowed.
mstemm
force-pushed
the
rule-updates-2018-02.v1
branch
from
05d048d to
fe82480
Compare
|
yeah, that was a typo on my part. I had changed it for testing, but hadn't changed it back. It's fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to reduce false positives as well as handling suggested use cases from customers.
@mattpag could you take a look at the last 2 commits (ssh/nodeport support?)